]> git.baikalelectronics.ru Git - kernel.git/commitdiff
Documentation/kcov: define `ip' in the example
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Tue, 9 Nov 2021 02:35:31 +0000 (18:35 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 9 Nov 2021 18:02:52 +0000 (10:02 -0800)
The example code uses the variable `ip' but never declares it.

Declare `ip' as a 64bit variable which is the same type as the array
from which it loads its value.

Link: https://lkml.kernel.org/r/20210923164741.1859522-3-bigeasy@linutronix.de
Link: https://lore.kernel.org/r/20210830172627.267989-3-bigeasy@linutronix.de
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Dmitry Vyukov <dvyukov@google.com>
Acked-by: Marco Elver <elver@google.com>
Tested-by: Marco Elver <elver@google.com>
Reviewed-by: Andrey Konovalov <andreyknvl@gmail.com>
Cc: Clark Williams <williams@redhat.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Documentation/dev-tools/kcov.rst

index 347f3b6de8d40a9b085fe9f3e3aee2c42a1575ad..d83c9ab494275e9925ae58cc26e5e6e653e3f76f 100644 (file)
@@ -178,6 +178,8 @@ Comparison operands collection is similar to coverage collection:
        /* Read number of comparisons collected. */
        n = __atomic_load_n(&cover[0], __ATOMIC_RELAXED);
        for (i = 0; i < n; i++) {
+               uint64_t ip;
+
                type = cover[i * KCOV_WORDS_PER_CMP + 1];
                /* arg1 and arg2 - operands of the comparison. */
                arg1 = cover[i * KCOV_WORDS_PER_CMP + 2];