]> git.baikalelectronics.ru Git - kernel.git/commit
netlink: remove the flex array from struct nlmsghdr
authorJakub Kicinski <kuba@kernel.org>
Fri, 18 Nov 2022 03:39:03 +0000 (19:39 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 10 Oct 2023 20:00:46 +0000 (22:00 +0200)
commitff81d1c77d0890b0cf835378614ba6df02de6cd8
tree3a1dea871caafa8764139658f771405d2d108af9
parent6cd57f5c779578c2c41f6ab3dedd71aaddca4d9f
netlink: remove the flex array from struct nlmsghdr

commit c73a72f4cbb47672c8cc7f7d7aba52f1cb15baca upstream.

I've added a flex array to struct nlmsghdr in
commit 738136a0e375 ("netlink: split up copies in the ack construction")
to allow accessing the data easily. It leads to warnings with clang,
if user space wraps this structure into another struct and the flex
array is not at the end of the container.

Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: David Ahern <dsahern@kernel.org>
Link: https://lore.kernel.org/all/20221114023927.GA685@u2004-local/
Link: https://lore.kernel.org/r/20221118033903.1651026-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/uapi/linux/netlink.h
net/netlink/af_netlink.c