]> git.baikalelectronics.ru Git - kernel.git/commit
selftests/bpf: Fix silent Makefile output
authorAndrii Nakryiko <andriin@fb.com>
Fri, 7 Aug 2020 03:30:57 +0000 (20:30 -0700)
committerDaniel Borkmann <daniel@iogearbox.net>
Fri, 7 Aug 2020 16:52:32 +0000 (18:52 +0200)
commitff20e068cadd7eca5ec3610539c8f640b02a1e56
tree1a4f3008e76259ab71b36e24e04270a03c947812
parentce367fc7f5c8bc3850f5d3251fa76f95f5238972
selftests/bpf: Fix silent Makefile output

b37d59b823ea ("selftests: do not use .ONESHELL") removed .ONESHELL, which
changes how Makefile "silences" multi-command target recipes. selftests/bpf's
Makefile relied (a somewhat unknowingly) on .ONESHELL behavior of silencing
all commands within the recipe if the first command contains @ symbol.
Removing .ONESHELL exposed this hack.

This patch fixes the issue by explicitly silencing each command with $(Q).

Also explicitly define fallback rule for building *.o from *.c, instead of
relying on non-silent inherited rule. This was causing a non-silent output for
bench.o object file.

Fixes: 6f3b1287d610 ("selftests/bpf: More succinct Makefile output")
Signed-off-by: Andrii Nakryiko <andriin@fb.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/bpf/20200807033058.848677-1-andriin@fb.com
tools/testing/selftests/bpf/Makefile