]> git.baikalelectronics.ru Git - kernel.git/commit
selinux: selinux_setprocattr()->ptrace_parent() needs rcu_read_lock()
authorOleg Nesterov <oleg@redhat.com>
Mon, 23 Dec 2013 22:45:01 +0000 (17:45 -0500)
committerPaul Moore <pmoore@redhat.com>
Mon, 23 Dec 2013 22:45:17 +0000 (17:45 -0500)
commitfe9739a53466bdc99d044bae60566fdcafc8d01f
treee430e1d9e869d9e08a0a7e8677951465568d17dc
parent94e9aca6bd725a8835382169841387a05e13b541
selinux: selinux_setprocattr()->ptrace_parent() needs rcu_read_lock()

selinux_setprocattr() does ptrace_parent(p) under task_lock(p),
but task_struct->alloc_lock doesn't pin ->parent or ->ptrace,
this looks confusing and triggers the "suspicious RCU usage"
warning because ptrace_parent() does rcu_dereference_check().

And in theory this is wrong, spin_lock()->preempt_disable()
doesn't necessarily imply rcu_read_lock() we need to access
the ->parent.

Reported-by: Evan McNabb <emcnabb@redhat.com>
Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Cc: stable@vger.kernel.org
Signed-off-by: Paul Moore <pmoore@redhat.com>
security/selinux/hooks.c