]> git.baikalelectronics.ru Git - kernel.git/commit
x86/dumpstack: Remove NULL task pointer convention
authorJosh Poimboeuf <jpoimboe@redhat.com>
Fri, 16 Sep 2016 13:05:20 +0000 (08:05 -0500)
committerIngo Molnar <mingo@kernel.org>
Fri, 16 Sep 2016 14:21:39 +0000 (16:21 +0200)
commitfe624f365dba414d7d9ef6ba7c4bc5a6577377c6
tree2172bf58d81411a56750134aaa08109a0b910c82
parent1282c5ea898e94c60bf74ccebde4b1f6f448b8e0
x86/dumpstack: Remove NULL task pointer convention

show_stack_log_lvl() and friends allow a NULL pointer for the
task_struct to indicate the current task.  This creates confusion and
can cause sneaky bugs.

Instead require the caller to pass 'current' directly.

This only changes the internal workings of the dumpstack code.  The
dump_trace() and show_stack() interfaces still allow a NULL task
pointer.  Those interfaces should also probably be fixed as well.

Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/include/asm/stacktrace.h
arch/x86/kernel/dumpstack.c
arch/x86/kernel/dumpstack_32.c
arch/x86/kernel/dumpstack_64.c