]> git.baikalelectronics.ru Git - kernel.git/commit
ethernet: hisilicon: hns: hns_dsaf_misc: fix a possible array overflow in hns_dsaf_ge...
authorTeng Qi <starmiku1207184332@gmail.com>
Wed, 17 Nov 2021 03:44:53 +0000 (11:44 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 18 Nov 2021 11:15:47 +0000 (11:15 +0000)
commitfe399d98a9386d62bb718e0bfad492add3511c9d
treeb11e9a25ab4ca26b0f2c907dcdfeb248ee035870
parent39bed040af67728e5adba95f780310434fe5950f
ethernet: hisilicon: hns: hns_dsaf_misc: fix a possible array overflow in hns_dsaf_ge_srst_by_port()

The if statement:
  if (port >= DSAF_GE_NUM)
        return;

limits the value of port less than DSAF_GE_NUM (i.e., 8).
However, if the value of port is 6 or 7, an array overflow could occur:
  port_rst_off = dsaf_dev->mac_cb[port]->port_rst_off;

because the length of dsaf_dev->mac_cb is DSAF_MAX_PORT_NUM (i.e., 6).

To fix this possible array overflow, we first check port and if it is
greater than or equal to DSAF_MAX_PORT_NUM, the function returns.

Reported-by: TOTE Robot <oslab@tsinghua.edu.cn>
Signed-off-by: Teng Qi <starmiku1207184332@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns/hns_dsaf_misc.c