]> git.baikalelectronics.ru Git - kernel.git/commit
gpio: amd8111: Fix PCI device reference count leak
authorXiongfeng Wang <wangxiongfeng2@huawei.com>
Tue, 22 Nov 2022 12:35:08 +0000 (20:35 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Dec 2022 10:30:44 +0000 (11:30 +0100)
commitfe03e0f4549fd0f5943274c0463701f8c9312a3b
tree4ff23dfc1a09d706f36a72171ddf62a3ac3b0f1a
parentaf2622d49acc0c43fd2c76b0271354a18e8c1e52
gpio: amd8111: Fix PCI device reference count leak

[ Upstream commit 45fecdb9f658d9c82960c98240bc0770ade19aca ]

for_each_pci_dev() is implemented by pci_get_device(). The comment of
pci_get_device() says that it will increase the reference count for the
returned pci_dev and also decrease the reference count for the input
pci_dev @from if it is not NULL.

If we break for_each_pci_dev() loop with pdev not NULL, we need to call
pci_dev_put() to decrease the reference count. Add the missing
pci_dev_put() after the 'out' label. Since pci_dev_put() can handle NULL
input parameter, there is no problem for the 'Device not found' branch.
For the normal path, add pci_dev_put() in amd_gpio_exit().

Fixes: 0215c02983ce ("gpio: add a driver for GPIO pins found on AMD-8111 south bridge chips")
Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpio/gpio-amd8111.c