]> git.baikalelectronics.ru Git - kernel.git/commit
powerpc/eeh: Fix partial hotplug criterion
authorGavin Shan <gwshan@linux.vnet.ibm.com>
Fri, 12 Feb 2016 05:03:05 +0000 (16:03 +1100)
committerMichael Ellerman <mpe@ellerman.id.au>
Mon, 22 Feb 2016 08:25:55 +0000 (19:25 +1100)
commitfd991d1960428885853a0f8a56979195c977f152
tree26f2719f43c59c9c027fea48f552d13a4badbf9a
parent7dffe607d2612717b403b735e3ee1e3992b5380c
powerpc/eeh: Fix partial hotplug criterion

During error recovery, the device could be removed as part of the
partial hotplug. The criterion used to come with partial hotplug
is: if the device driver provides error_detected(), slot_reset()
and resume() callbacks, it's immune from hotplug. Otherwise,
it's going to experience partial hotplug during EEH recovery. But
the criterion isn't correct enough: mlx4_core driver for Mellanox
adapters provides error_detected(), slot_reset() callbacks, but
resume() isn't there. Those Mellanox adapters won't be to involved
in the partial hotplug.

This fixes the criterion to a practical one: adpater with driver
that provides error_detected(), slot_reset() will be immune from
partial hotplug. resume() isn't mandatory.

Fixes: 26a14f3f ("powerpc/eeh: More relaxed hotplug criterion")
Cc: stable@vger.kernel.org #v4.4+
Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
arch/powerpc/kernel/eeh_driver.c