]> git.baikalelectronics.ru Git - kernel.git/commit
net: mscc: ocelot: fix address ageing time (again)
authorVladimir Oltean <vladimir.oltean@nxp.com>
Thu, 21 May 2020 21:31:23 +0000 (00:31 +0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 22 May 2020 23:15:21 +0000 (16:15 -0700)
commitfd7b53672e9e0ee48128afa2164c4b0c95a72908
tree40c3618974469a5e2dfc7c71d8c98742ba2fa2bd
parent2d68d5411accaa82e9ba7e35783cf79b4161024f
net: mscc: ocelot: fix address ageing time (again)

ocelot_set_ageing_time has 2 callers:
 - felix_set_ageing_time: from drivers/net/dsa/ocelot/felix.c
 - ocelot_port_attr_ageing_set: from drivers/net/ethernet/mscc/ocelot.c

The issue described in the fixed commit below actually happened for the
felix_set_ageing_time code path only, since ocelot_port_attr_ageing_set
was already dividing by 1000. So to make both paths symmetrical (and to
fix addresses getting aged way too fast on Ocelot), stop dividing by
1000 at caller side altogether.

Fixes: 4a814bc07dbd ("net: mscc: ocelot: ANA_AUTOAGE_AGE_PERIOD holds a value in seconds, not ms")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mscc/ocelot.c