]> git.baikalelectronics.ru Git - kernel.git/commit
mac80211: fix regression where EAPOL frames were sent in plaintext
authorMathy Vanhoef <Mathy.Vanhoef@kuleuven.be>
Mon, 19 Oct 2020 16:01:13 +0000 (20:01 +0400)
committerJohannes Berg <johannes.berg@intel.com>
Fri, 30 Oct 2020 09:03:24 +0000 (10:03 +0100)
commitfcfeeb3853f82a3cae264de03456fadfd73bdcd7
treecca11e06b25076b2f6ebb3e9c482b451bf3afc38
parent64400aefc6dbc40271351ea5e8e611705c0d7189
mac80211: fix regression where EAPOL frames were sent in plaintext

When sending EAPOL frames via NL80211 they are treated as injected
frames in mac80211. Due to commit 8205b982d5b3 ("mac80211: never drop
injected frames even if normally not allowed") these injected frames
were not assigned a sta context in the function ieee80211_tx_dequeue,
causing certain wireless network cards to always send EAPOL frames in
plaintext. This may cause compatibility issues with some clients or
APs, which for instance can cause the group key handshake to fail and
in turn would cause the station to get disconnected.

This commit fixes this regression by assigning a sta context in
ieee80211_tx_dequeue to injected frames as well.

Note that sending EAPOL frames in plaintext is not a security issue
since they contain their own encryption and authentication protection.

Cc: stable@vger.kernel.org
Fixes: 8205b982d5b3 ("mac80211: never drop injected frames even if normally not allowed")
Reported-by: Thomas Deutschmann <whissi@gentoo.org>
Tested-by: Christian Hesse <list@eworm.de>
Tested-by: Thomas Deutschmann <whissi@gentoo.org>
Signed-off-by: Mathy Vanhoef <Mathy.Vanhoef@kuleuven.be>
Link: https://lore.kernel.org/r/20201019160113.350912-1-Mathy.Vanhoef@kuleuven.be
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/tx.c