]> git.baikalelectronics.ru Git - kernel.git/commit
mmc: tmio_mmc_core: don't claim spurious interrupts
authorSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Mon, 18 Feb 2019 17:45:40 +0000 (20:45 +0300)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 25 Feb 2019 16:25:13 +0000 (17:25 +0100)
commitfcc794302c813a87abd7f7a6ba734315dc124cf3
treefaaa0b0e224a3db7ce7b4349cf2814064b955e73
parent8e6735bdd77e9c533d8f68a5fd089ee33e7aefa9
mmc: tmio_mmc_core: don't claim spurious interrupts

I have encountered an interrupt storm during the eMMC chip probing (and
the chip finally didn't get detected).  It turned out that U-Boot left
the DMAC interrupts enabled while the Linux driver  didn't use those.
The SDHI driver's interrupt handler somehow assumes that, even if an
SDIO interrupt didn't happen, it should return IRQ_HANDLED.  I think
that if none of the enabled interrupts happened and got handled, we
should return IRQ_NONE -- that way the kernel IRQ code recoginizes
a spurious interrupt and masks it off pretty quickly...

Fixes: d9438192dbaf ("mmc: tmio: Provide separate interrupt handlers")
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Tested-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Cc: stable@vger.kernel.org
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/tmio_mmc_core.c