]> git.baikalelectronics.ru Git - kernel.git/commit
net: dsa: bcm_sf2: Fix bcm_sf2_reg_rgmii_cntrl() call for non-RGMII port
authorFlorian Fainelli <f.fainelli@gmail.com>
Fri, 21 May 2021 17:46:14 +0000 (10:46 -0700)
committerDavid S. Miller <davem@davemloft.net>
Fri, 21 May 2021 21:18:34 +0000 (14:18 -0700)
commitfc516d3a6aa2c6ffe27d0da8818d13839e023e7e
tree38df99cdc4ec17df3d9970d84d2f2bd04610e220
parente5bfaed7508fd34ae95a79d1eb76c38ecc82c947
net: dsa: bcm_sf2: Fix bcm_sf2_reg_rgmii_cntrl() call for non-RGMII port

We cannot call bcm_sf2_reg_rgmii_cntrl() for a port that is not RGMII,
yet we do that in bcm_sf2_sw_mac_link_up() irrespective of the port's
interface. Move that read until we have properly qualified the PHY
interface mode. This avoids triggering a warning on 7278 platforms that
have GMII ports.

Fixes: 55cfeb396965 ("net: dsa: bcm_sf2: add function finding RGMII register")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Rafał Miłecki <rafal@milecki.pl>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/bcm_sf2.c