]> git.baikalelectronics.ru Git - kernel.git/commit
mlx5e: add add missing BH locking around napi_schdule()
authorJakub Kicinski <kuba@kernel.org>
Wed, 5 May 2021 20:20:26 +0000 (13:20 -0700)
committerSaeed Mahameed <saeedm@nvidia.com>
Wed, 19 May 2021 06:01:55 +0000 (23:01 -0700)
commitfc3ff6363e49b51b5e9deeff3b4c65e1868ca3a6
treec11ae251b8bccc6cc9789315acbb293131cd81e4
parent99b7fc4ff0b63edfb86870b394fab7a7981aed0a
mlx5e: add add missing BH locking around napi_schdule()

It's not correct to call napi_schedule() in pure process
context. Because we use __raise_softirq_irqoff() we require
callers to be in a context which will eventually lead to
softirq handling (hardirq, bh disabled, etc.).

With code as is users will see:

 NOHZ tick-stop error: Non-RCU local softirq work is pending, handler #08!!!

Fixes: cc09943f626d ("net/mlx5e: Generalize RQ activation")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
drivers/net/ethernet/mellanox/mlx5/core/en_main.c