]> git.baikalelectronics.ru Git - kernel.git/commit
pci: Fix hotplug of Express Module with pci bridges
authorYinghai Lu <yinghai@kernel.org>
Sun, 18 Dec 2011 02:33:37 +0000 (18:33 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sun, 18 Dec 2011 22:10:16 +0000 (14:10 -0800)
commitfc3d276b4a080c8cc91684807b2f34572eb6133d
tree8827d2d1d515dc1ea34d63965bf93e9ee21ae9bc
parentbf2c05706dd373fa041104f0f5dd6411b3d20cf4
pci: Fix hotplug of Express Module with pci bridges

I noticed that hotplug of one setup does not work with recent change in
pci tree.

After checking the bridge conf setup, I noticed that the bridges get
assigned but do not get enabled.

The reason is the following commit, while simply ignores bridge
resources when enabling a pci device:

| commit 3dddda4316760bfbcc45f45af1a832ae7ec295a2
| Author: Ram Pai <linuxram@us.ibm.com>
| Date:   Sun Nov 6 10:33:10 2011 +0800
|
|    PCI: defer enablement of SRIOV BARS
|...
|    NOTE: Note, there is subtle change in the pci_enable_device() API.  Any
|    driver that depends on SRIOV BARS to be enabled in pci_enable_device()
|    can fail.

Put back bridge resource and ROM resource checking to fix the problem.

That should fix regression like BIOS does not assign correct resource to
bridge.

Discussion can be found at:
http://www.spinics.net/lists/linux-pci/msg12874.html

Signed-off-by: Yinghai Lu <yinghai@kernel.org>
Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/pci/pci.c