]> git.baikalelectronics.ru Git - kernel.git/commit
firewire-motu: fix wrong reference count for stream functionality at error path of...
authorTakashi Sakamoto <o-takashi@sakamocchi.jp>
Sun, 7 Jul 2019 05:20:11 +0000 (14:20 +0900)
committerTakashi Iwai <tiwai@suse.de>
Sun, 7 Jul 2019 09:19:58 +0000 (11:19 +0200)
commitfba33de41a08cb7518fa75ba413dc93fbda85723
tree9e4cc41494c3662b25df79515e31af647f6101c0
parent64844ab28b171f664392cbadc2d62f1905af1310
firewire-motu: fix wrong reference count for stream functionality at error path of rawmidi interface

In IEC 61883-6, several types of sampling data can be multiplexed into
payload of common isochronous packet (CIP). For typical audio and music
units, PCM samples and MIDI messages are multiplexed into one packet
streaming.

ALSA firewire-motu driver allows applications of rawmidi interface to
start packet streaming for transmission of MIDI messages. However at
error path, the reference count of stream functionality is not operated
correctly. This can brings a bug that packet streaming is not stopped
when all referrers release the count.

This commit fixes the bug.

Fixes: 60a60b22a08e ("ALSA: firewire-motu: reserve/release isochronous resources in pcm.hw_params/hw_free callbacks")
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/firewire/motu/motu-midi.c