]> git.baikalelectronics.ru Git - kernel.git/commit
ALSA: galaxy: Fix the missing snd_card_free() call at probe error
authorTakashi Iwai <tiwai@suse.de>
Tue, 12 Apr 2022 10:25:58 +0000 (12:25 +0200)
committerTakashi Iwai <tiwai@suse.de>
Tue, 12 Apr 2022 15:58:16 +0000 (17:58 +0200)
commitfb96e0e37bfee8d38224398b66dec16e8b3235d6
treee3cde7c2dd8bd1585337350c160230d6309f45a5
parentf63374513ada795ee6e14c96cb2f0f2f86d17dc6
ALSA: galaxy: Fix the missing snd_card_free() call at probe error

The previous cleanup with devres may lead to the incorrect release
orders at the probe error handling due to the devres's nature.  Until
we register the card, snd_card_free() has to be called at first for
releasing the stuff properly when the driver tries to manage and
release the stuff via card->private_free().

This patch fixes it by calling snd_card_free() on the error from the
probe callback using a new helper function.

Fixes: dcf4c35ead76 ("ALSA: galaxy: Allocate resources with device-managed APIs")
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20220412102636.16000-2-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/isa/galaxy/galaxy.c