]> git.baikalelectronics.ru Git - kernel.git/commit
drm/bridge/synopsys: dw-hdmi: Fix unwedge crash when no pinctrl entries
authorDouglas Anderson <dianders@chromium.org>
Mon, 10 Jun 2019 17:52:34 +0000 (10:52 -0700)
committerSean Paul <seanpaul@chromium.org>
Mon, 10 Jun 2019 19:14:57 +0000 (15:14 -0400)
commitfb8787bfe62f2ccb07f85147f82a48cb0b5290d6
treeec6355faf2790b4bf54bc2fcfe3766f86dca70f8
parent371dd63cb5500d00fe2f56893c20bfdd0f8f3458
drm/bridge/synopsys: dw-hdmi: Fix unwedge crash when no pinctrl entries

In commit 46a94b16fa08 ("drm/bridge/synopsys: dw-hdmi: Add "unwedge"
for ddc bus") I stupidly used IS_ERR() to check for whether we have an
"unwedge" pinctrl state even though on most flows through the driver
the unwedge state will just be NULL.

Fix it so that we consistently use NULL for no unwedge state.

Fixes: 46a94b16fa08 ("drm/bridge/synopsys: dw-hdmi: Add "unwedge" for ddc bus")
Cc: Douglas Anderson <dianders@chromium.org>
Cc: Sean Paul <seanpaul@chromium.org>
Cc: Andrzej Hajda <a.hajda@samsung.com>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Neil Armstrong <narmstrong@baylibre.com>
Cc: Jonas Karlman <jonas@kwiboo.se>
Cc: Jernej Skrabec <jernej.skrabec@siol.net>
Cc: Sam Ravnborg <sam@ravnborg.org>
Reported-by: Erico Nunes <nunes.erico@gmail.com>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20190610175234.196844-1-dianders@chromium.org
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c