]> git.baikalelectronics.ru Git - kernel.git/commit
sctp: do not allow the v4 socket to bind a v4mapped v6 address
authorXin Long <lucien.xin@gmail.com>
Mon, 15 Jan 2018 09:02:00 +0000 (17:02 +0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 16 Jan 2018 19:24:20 +0000 (14:24 -0500)
commitfb7d0c29340cd2f721c20785922c3f052551d285
tree116feac3332f40168ff3ba971256564bcb9b2b3f
parent02d4d60427b054f243443ea40735093e1e3ffc74
sctp: do not allow the v4 socket to bind a v4mapped v6 address

The check in sctp_sockaddr_af is not robust enough to forbid binding a
v4mapped v6 addr on a v4 socket.

The worse thing is that v4 socket's bind_verify would not convert this
v4mapped v6 addr to a v4 addr. syzbot even reported a crash as the v4
socket bound a v6 addr.

This patch is to fix it by doing the common sa.sa_family check first,
then AF_INET check for v4mapped v6 addrs.

Fixes: cc1aac6e4431 ("sctp: Support ipv6only AF_INET6 sockets.")
Reported-by: syzbot+7b7b518b1228d2743963@syzkaller.appspotmail.com
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/socket.c