]> git.baikalelectronics.ru Git - kernel.git/commit
ice: fix possible under reporting of ethtool Tx and Rx statistics
authorPaul Greenwalt <paul.greenwalt@intel.com>
Thu, 28 Apr 2022 21:11:42 +0000 (14:11 -0700)
committerTony Nguyen <anthony.l.nguyen@intel.com>
Tue, 17 May 2022 17:37:09 +0000 (10:37 -0700)
commitfb5ee8fac5160122ef74ad02117159547e6f2ebf
treea706a3b6780f3845735877b2fa5c06c432c5d414
parent0a84596a08252870f4f357619cbe2bdbc19cef51
ice: fix possible under reporting of ethtool Tx and Rx statistics

The hardware statistics counters are not cleared during resets so the
drivers first access is to initialize the baseline and then subsequent
reads are for reporting the counters. The statistics counters are read
during the watchdog subtask when the interface is up. If the baseline
is not initialized before the interface is up, then there can be a brief
window in which some traffic can be transmitted/received before the
initial baseline reading takes place.

Directly initialize ethtool statistics in driver open so the baseline will
be initialized when the interface is up, and any dropped packets
incremented before the interface is up won't be reported.

Fixes: e5885b1286785 ("ice: ignore dropped packets during init")
Signed-off-by: Paul Greenwalt <paul.greenwalt@intel.com>
Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Intel)
Signed-off-by: Tony Nguyen <anthony.l.nguyen@intel.com>
drivers/net/ethernet/intel/ice/ice_main.c