]> git.baikalelectronics.ru Git - kernel.git/commit
tracing: Fix check for cpu online when event is disabled
authorSteven Rostedt (Red Hat) <rostedt@goodmis.org>
Wed, 9 Mar 2016 16:58:41 +0000 (11:58 -0500)
committerSteven Rostedt <rostedt@goodmis.org>
Wed, 9 Mar 2016 16:58:41 +0000 (11:58 -0500)
commitfb23ee91a617de841ee244d5dfcabac83ef79a8a
tree16187ae1d87d3b09619b452ac9e13864aa12aff2
parentf4d3bdec7ff21d94a2938f7193f1292bbb986036
tracing: Fix check for cpu online when event is disabled

Commit 20d8c18aa1b20 ("tracepoints: Do not trace when cpu is offline") added
a check to make sure that tracepoints only get called when the cpu is
online, as it uses rcu_read_lock_sched() for protection.

Commit f3c1ec79fc815 ("tracing: generate RCU warnings even when tracepoints
are disabled") added lockdep checks (including rcu checks) for events that
are not enabled to catch possible RCU issues that would only be triggered if
a trace event was enabled. Commit 20d8c18aa1b20 only stopped the warnings
when the trace event was enabled but did not prevent warnings if the trace
event was called when disabled.

To fix this, the cpu online check is moved to where the condition is added
to the trace event. This will place the cpu online check in all places that
it may be used now and in the future.

Cc: stable@vger.kernel.org # v3.18+
Fixes: 20d8c18aa1b20 ("tracepoints: Do not trace when cpu is offline")
Fixes: f3c1ec79fc815 ("tracing: generate RCU warnings even when tracepoints are disabled")
Reported-by: Sudeep Holla <sudeep.holla@arm.com>
Tested-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
include/linux/tracepoint.h