]> git.baikalelectronics.ru Git - kernel.git/commit
flow_dissect: call init_default_flow_dissectors() earlier
authorEric Dumazet <edumazet@google.com>
Tue, 22 Nov 2016 19:17:30 +0000 (11:17 -0800)
committerDavid S. Miller <davem@davemloft.net>
Tue, 22 Nov 2016 19:44:01 +0000 (14:44 -0500)
commitfa6f658fbe9c20c62988b50b053414b99b28b7ec
tree593c0ab3b462dc9e1c9754d302ade8b9adb0dd1c
parentb4bc79a141d45cc74fad1990bebcb1039d50ceba
flow_dissect: call init_default_flow_dissectors() earlier

Andre Noll reported panics after my recent fix (commit 723a88d344d3
"net: __skb_flow_dissect() must cap its return value")

After some more headaches, Alexander root caused the problem to
init_default_flow_dissectors() being called too late, in case
a network driver like IGB is not a module and receives DHCP message
very early.

Fix is to call init_default_flow_dissectors() much earlier,
as it is a core infrastructure and does not depend on another
kernel service.

Fixes: d943d93e8a8d6 ("flow_dissect: use programable dissector in skb_flow_dissect and friends")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: Andre Noll <maan@tuebingen.mpg.de>
Diagnosed-by: Alexander Duyck <alexander.h.duyck@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/flow_dissector.c