]> git.baikalelectronics.ru Git - kernel.git/commit
kconfig: qconf: remove qInfo() to get back Qt4 support
authorMasahiro Yamada <masahiroy@kernel.org>
Thu, 20 Aug 2020 15:16:46 +0000 (00:16 +0900)
committerMasahiro Yamada <masahiroy@kernel.org>
Fri, 21 Aug 2020 01:22:46 +0000 (10:22 +0900)
commitfa69f9f5f03e0a6e38ee0e8b7e506158f98d7d49
treee350992369b92d599ae135c851fc932a6de75fd6
parent0fcb87c116051777d969e6d6bdc70fb89024013d
kconfig: qconf: remove qInfo() to get back Qt4 support

qconf is supposed to work with Qt4 and Qt5, but since commit
da3ebf8b1332 ("kconfig: qconf: make debug links work again"),
building with Qt4 fails as follows:

  HOSTCXX scripts/kconfig/qconf.o
scripts/kconfig/qconf.cc: In member function ‘void ConfigInfoView::clicked(const QUrl&)’:
scripts/kconfig/qconf.cc:1241:3: error: ‘qInfo’ was not declared in this scope; did you mean ‘setInfo’?
 1241 |   qInfo() << "Clicked link is empty";
      |   ^~~~~
      |   setInfo
scripts/kconfig/qconf.cc:1254:3: error: ‘qInfo’ was not declared in this scope; did you mean ‘setInfo’?
 1254 |   qInfo() << "Clicked symbol is invalid:" << data;
      |   ^~~~~
      |   setInfo
make[1]: *** [scripts/Makefile.host:129: scripts/kconfig/qconf.o] Error 1
make: *** [Makefile:606: xconfig] Error 2

qInfo() does not exist in Qt4. In my understanding, these call-sites
should be unreachable. Perhaps, qWarning(), assertion, or something
is better, but qInfo() is not the right one to use here, I think.

Fixes: da3ebf8b1332 ("kconfig: qconf: make debug links work again")
Reported-by: Ronald Warsow <rwarsow@gmx.de>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
scripts/kconfig/qconf.cc