]> git.baikalelectronics.ru Git - kernel.git/commit
HID: check empty report_list in hid_validate_values()
authorPietro Borrello <borrello@diag.uniroma1.it>
Mon, 16 Jan 2023 11:11:24 +0000 (11:11 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 6 Feb 2023 06:52:38 +0000 (07:52 +0100)
commitf9fd71b3dadb54d2d40386b4725a6a6240d62219
tree97fe2a1de7fe750fa0f28fce0883b7d621fedea2
parentd2457018c948e94ca13a49c6521f64630e633cec
HID: check empty report_list in hid_validate_values()

[ Upstream commit b12fece4c64857e5fab4290bf01b2e0317a88456 ]

Add a check for empty report_list in hid_validate_values().
The missing check causes a type confusion when issuing a list_entry()
on an empty report_list.
The problem is caused by the assumption that the device must
have valid report_list. While this will be true for all normal HID
devices, a suitably malicious device can violate the assumption.

Fixes: d94b10af9775 ("HID: core: fix validation of report id 0")
Signed-off-by: Pietro Borrello <borrello@diag.uniroma1.it>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/hid/hid-core.c