]> git.baikalelectronics.ru Git - kernel.git/commit
watchdog: iTCO_wdt: Drop option vendorsupport=2
authorJean Delvare <jdelvare@suse.de>
Fri, 31 Aug 2018 13:06:10 +0000 (15:06 +0200)
committerWim Van Sebroeck <wim@linux-watchdog.org>
Tue, 2 Oct 2018 11:32:24 +0000 (13:32 +0200)
commitf9f920cd5f78e49da2ebf59e308b76f0b4ed5807
tree9beea65eac2a31d114c4d15a01c8621493414dbd
parent655d7be1aa34621015ee628b34e64e4e4b8b2c7d
watchdog: iTCO_wdt: Drop option vendorsupport=2

iTCO_vendor_support's option vendorsupport=2 is a gross hack. It
claims to extend the existing iTCO_wdt driver, but in fact programs
a watchdog on a completely different device (Super-I/O) without
requesting its I/O ports and without checking the device ID. This is
an utterly dangerous thing to do.

It also turns out to be unnecessary, because as far as I can tell, the
code in question is basically duplicating what the clean w83627hf_wdt
driver is doing.

My guess is that on these SuperMicro boards which sparkled the
implementation of vendorsupport=2, the watchdog functionality of the
Intel south bridge is not used, and the watchdog feature of some
W83627HF-like Super-I/O chip is used instead. So we should point the
users to the w83627hf_wdt driver.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Martin Wilck <mwilck@suse.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
drivers/watchdog/iTCO_vendor_support.c