]> git.baikalelectronics.ru Git - kernel.git/commit
net/l2tp: Fix reference count leak in l2tp_udp_recv_core
authorXiyu Yang <xiyuyang19@fudan.edu.cn>
Thu, 9 Sep 2021 04:32:00 +0000 (12:32 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 22 Sep 2021 10:26:41 +0000 (12:26 +0200)
commitf9b29d9ca68d6c263e6670f7a64068342dec7a43
treefb3f81b6799affb22b5fa93e9a90a4ad7ebf9cee
parent76c08af5ae9f608d570bb3fdef02d32aea2371f6
net/l2tp: Fix reference count leak in l2tp_udp_recv_core

commit 9b6ff7eb666415e1558f1ba8a742f5db6a9954de upstream.

The reference count leak issue may take place in an error handling
path. If both conditions of tunnel->version == L2TP_HDR_VER_3 and the
return value of l2tp_v3_ensure_opt_in_linear is nonzero, the function
would directly jump to label invalid, without decrementing the reference
count of the l2tp_session object session increased earlier by
l2tp_tunnel_get_session(). This may result in refcount leaks.

Fix this issue by decrease the reference count before jumping to the
label invalid.

Fixes: 7ad9ead2b558 ("l2tp: fix reading optional fields of L2TPv3")
Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: Xin Xiong <xiongx18@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/l2tp/l2tp_core.c