]> git.baikalelectronics.ru Git - kernel.git/commit
mqueue: fix a use-after-free in sys_mq_notify()
authorCong Wang <xiyou.wangcong@gmail.com>
Sun, 9 Jul 2017 20:19:55 +0000 (13:19 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Sun, 9 Jul 2017 21:37:19 +0000 (14:37 -0700)
commitf991af3daabaecff34684fd51fac80319d1baad1
tree7f71fafa6bf93eb11a214aa9758036482923ee0b
parent2b976203417cf033079e0be30cae5f41d88e385e
mqueue: fix a use-after-free in sys_mq_notify()

The retry logic for netlink_attachskb() inside sys_mq_notify()
is nasty and vulnerable:

1) The sock refcnt is already released when retry is needed
2) The fd is controllable by user-space because we already
   release the file refcnt

so we when retry but the fd has been just closed by user-space
during this small window, we end up calling netlink_detachskb()
on the error path which releases the sock again, later when
the user-space closes this socket a use-after-free could be
triggered.

Setting 'sock' to NULL here should be sufficient to fix it.

Reported-by: GeneBlue <geneblue.mail@gmail.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Manfred Spraul <manfred@colorfullife.com>
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
ipc/mqueue.c