]> git.baikalelectronics.ru Git - kernel.git/commit
llc: set SOCK_RCU_FREE in llc_sap_add_socket()
authorCong Wang <xiyou.wangcong@gmail.com>
Thu, 11 Oct 2018 18:15:13 +0000 (11:15 -0700)
committerDavid S. Miller <davem@davemloft.net>
Tue, 16 Oct 2018 05:01:37 +0000 (22:01 -0700)
commitf939a16064d32ed92a378f409e6e4f7400ededf5
treeeadd98d8a321daa8892ba298d62000ed3eb86fca
parentcf88abc0d22aab9448518967372f5c7e137b2e64
llc: set SOCK_RCU_FREE in llc_sap_add_socket()

WHen an llc sock is added into the sk_laddr_hash of an llc_sap,
it is not marked with SOCK_RCU_FREE.

This causes that the sock could be freed while it is still being
read by __llc_lookup_established() with RCU read lock. sock is
refcounted, but with RCU read lock, nothing prevents the readers
getting a zero refcnt.

Fix it by setting SOCK_RCU_FREE in llc_sap_add_socket().

Reported-by: syzbot+11e05f04c15e03be5254@syzkaller.appspotmail.com
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/llc/llc_conn.c