]> git.baikalelectronics.ru Git - kernel.git/commit
nfsd4: fix acl buffer overrun
authorJ. Bruce Fields <bfields@redhat.com>
Tue, 11 Feb 2014 16:29:05 +0000 (11:29 -0500)
committerJ. Bruce Fields <bfields@redhat.com>
Tue, 11 Feb 2014 18:48:11 +0000 (13:48 -0500)
commitf8ea99851a4095a7bd39ad7b5b9033dd383bfc45
treed345805a52a70a88485037122e577f1edebc9441
parent4833216bbefc757fb955f83b3b69afb65eb1f015
nfsd4: fix acl buffer overrun

d4a55e62bdfb6670c41e21f0fe3b60223a509f12 "nfsd: use get_acl and
->set_acl" forgets to set the size in the case get_acl() succeeds, so
_posix_to_nfsv4_one() can then write past the end of its allocation.
Symptoms were slab corruption warnings.

Also, some minor cleanup while we're here.  (Among other things, note
that the first few lines guarantee that pacl is non-NULL.)

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
fs/nfsd/nfs4acl.c