]> git.baikalelectronics.ru Git - kernel.git/commit
PM / runtime: Drop children check from __pm_runtime_set_status()
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 16 Nov 2017 21:51:22 +0000 (22:51 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 16 Nov 2017 21:51:22 +0000 (22:51 +0100)
commitf8817f61e8215b0ff1b73a0d33fa04ef9e6bce8b
tree6c90b8f2ee96d1a384f96f437e05d4d937a7fdae
parentbd2cd7d5a8f83ddc761025f42a3ca8e56351a6cc
PM / runtime: Drop children check from __pm_runtime_set_status()

The check for "active" children in __pm_runtime_set_status(), when
trying to set the parent device status to "suspended", doesn't
really make sense, because in fact it is not invalid to set the
status of a device with runtime PM disabled to "suspended" in any
case.  It is invalid to enable runtime PM for a device with its
status set to "suspended" while its child_count reference counter
is nonzero, but the check in __pm_runtime_set_status() doesn't
really cover that situation.

For this reason, drop the children check from __pm_runtime_set_status()
and add a check against child_count reference counters of "suspended"
devices to pm_runtime_enable().

Fixes: a8636c89648a (PM / Runtime: Don't allow to suspend a device with an active child)
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Reviewed-by: Johan Hovold <johan@kernel.org>
Documentation/power/runtime_pm.txt
drivers/base/power/runtime.c