]> git.baikalelectronics.ru Git - kernel.git/commit
net: bcmgenet: Remove phy_stop() from bcmgenet_netif_stop()
authorFlorian Fainelli <f.fainelli@gmail.com>
Thu, 4 May 2023 23:07:27 +0000 (16:07 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 30 May 2023 11:44:05 +0000 (12:44 +0100)
commitf844807de09334d37bc62860d90fe9e21689cee9
treeaadf1490a3b2a3dd173e89eae4308184189f1c9f
parent8a2cc0c8ba3e7dbb8cfea370733004d528e372a7
net: bcmgenet: Remove phy_stop() from bcmgenet_netif_stop()

[ Upstream commit 93e0401e0fc0c54b0ac05b687cd135c2ac38187c ]

The call to phy_stop() races with the later call to phy_disconnect(),
resulting in concurrent phy_suspend() calls being run from different
CPUs. The final call to phy_disconnect() ensures that the PHY is
stopped and suspended, too.

Fixes: 6601d5a7c259 ("net: bcmgenet: connect and disconnect from the PHY state machine")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/broadcom/genet/bcmgenet.c