]> git.baikalelectronics.ru Git - kernel.git/commit
Revert "net: stmmac: Do not keep rearming the coalesce timer in stmmac_xmit"
authorJerome Brunet <jbrunet@baylibre.com>
Fri, 24 Aug 2018 09:04:40 +0000 (11:04 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 30 Aug 2018 01:04:17 +0000 (18:04 -0700)
commitf80d79538169f6d3a75cf1b77f51056433ae9182
tree7b8d5b4b999ecff4f495138648ec4113b8940a06
parentb402c8469ce1654cb0a692ee5137106a7887047c
Revert "net: stmmac: Do not keep rearming the coalesce timer in stmmac_xmit"

This reverts commit 1f5cb7ac0da2d086f34aef5fb5d711d8a14f6ef3.

This change in the handling of the coalesce timer is causing regression on
(at least) amlogic platforms.

Network will break down very quickly (a few seconds) after starting
a download. This can easily be reproduced using iperf3 for example.

The problem has been reported on the S805, S905, S912 and A113 SoCs
(Realtek and Micrel PHYs) and it is likely impacting all Amlogics
platforms using Gbit ethernet

No problem was seen with the platform using 10/100 only PHYs (GXL internal)

Reverting change brings things back to normal and allows to use network
again until we better understand the problem with the coalesce timer.

Cc: Jose Abreu <joabreu@synopsys.com>
Cc: Joao Pinto <jpinto@synopsys.com>
Cc: Vitor Soares <soares@synopsys.com>
Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: Alexandre Torgue <alexandre.torgue@st.com>
Cc: Corentin Labbe <clabbe@baylibre.com>
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/stmmac.h
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c