]> git.baikalelectronics.ru Git - kernel.git/commit
sctp: move sk_route_caps check and set into sctp_outq_flush_transports
authorXin Long <lucien.xin@gmail.com>
Fri, 19 Mar 2021 03:52:41 +0000 (11:52 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 19 Mar 2021 18:34:49 +0000 (11:34 -0700)
commitf76a902da992f051ab814b9c2c0faae85bb88dfb
treec5958fb0a79dacfa5aa9218f07723befa2189771
parent5c1b27aac4db1ca992081ccbfbb5ed8a2ddc4ee4
sctp: move sk_route_caps check and set into sctp_outq_flush_transports

The sk's sk_route_caps is set in sctp_packet_config, and later it
only needs to change when traversing the transport_list in a loop,
as the dst might be changed in the tx path.

So move sk_route_caps check and set into sctp_outq_flush_transports
from sctp_packet_transmit. This also fixes a dst leak reported by
Chen Yi:

  https://bugzilla.kernel.org/show_bug.cgi?id=212227

As calling sk_setup_caps() in sctp_packet_transmit may also set the
sk_route_caps for the ctrl sock in a netns. When the netns is being
deleted, the ctrl sock's releasing is later than dst dev's deleting,
which will cause this dev's deleting to hang and dmesg error occurs:

  unregister_netdevice: waiting for xxx to become free. Usage count = 1

Reported-by: Chen Yi <yiche@redhat.com>
Fixes: fc02dd43bd02 ("sctp: call sk_setup_caps in sctp_packet_transmit instead")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sctp/output.c
net/sctp/outqueue.c