]> git.baikalelectronics.ru Git - kernel.git/commit
net: usb: rtl8150: set random MAC address when set_ethernet_addr() fails
authorAnant Thazhemadam <anant.thazhemadam@gmail.com>
Mon, 5 Oct 2020 13:29:58 +0000 (18:59 +0530)
committerDavid S. Miller <davem@davemloft.net>
Tue, 6 Oct 2020 13:10:21 +0000 (06:10 -0700)
commitf767fad1e2003adafeae420986a4bcbe68b1b856
tree9c719771c1b5a6968fb033aacae8303ab6950640
parent6ddc31cc71bd2c1d8e0aa16453622d2ae786de5a
net: usb: rtl8150: set random MAC address when set_ethernet_addr() fails

When get_registers() fails in set_ethernet_addr(),the uninitialized
value of node_id gets copied over as the address.
So, check the return value of get_registers().

If get_registers() executed successfully (i.e., it returns
sizeof(node_id)), copy over the MAC address using ether_addr_copy()
(instead of using memcpy()).

Else, if get_registers() failed instead, a randomly generated MAC
address is set as the MAC address instead.

Reported-by: syzbot+abbc768b560c84d92fd3@syzkaller.appspotmail.com
Tested-by: syzbot+abbc768b560c84d92fd3@syzkaller.appspotmail.com
Acked-by: Petko Manolov <petkan@nucleusys.com>
Signed-off-by: Anant Thazhemadam <anant.thazhemadam@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/usb/rtl8150.c