]> git.baikalelectronics.ru Git - kernel.git/commit
video: bfin_adv7393fb: Fix cleanup code
authorEmil Goode <emilgoode@gmail.com>
Mon, 28 May 2012 16:54:51 +0000 (18:54 +0200)
committerFlorian Tobias Schandinat <FlorianSchandinat@gmx.de>
Tue, 29 May 2012 13:16:45 +0000 (13:16 +0000)
commitf750f40001f2fffaa4cfabe462e3c8dc37602a92
tree03079676703d79f2e2e57734ab2e8fe6a0109516
parent6ce35a946a93745f81a50a83014b1ef92ff80bda
video: bfin_adv7393fb: Fix cleanup code

This patch fixes the cleanup code of the bfin_adv7393_fb_probe
function.

1) The resources were not freed in the order that we allocated them
   so we call dma_free_coherent() before it was allocated.
2) The labels weren't in the right place which also meant that we
   freed resources that weren't allocated.
3) We should free gpio_free(P_IDENT(P_PPI0_FS3)) before returning.
4) Lets change the label names into something more meaningful.

Signed-off-by: Emil Goode <emilgoode@gmail.com>
Acked-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
drivers/video/bfin_adv7393fb.c