]> git.baikalelectronics.ru Git - kernel.git/commit
net/bpfilter: fix dprintf usage for /dev/kmsg
authorBruno Meneguele <bmeneg@redhat.com>
Thu, 12 Mar 2020 23:08:20 +0000 (20:08 -0300)
committerDavid S. Miller <davem@davemloft.net>
Sun, 15 Mar 2020 03:58:10 +0000 (20:58 -0700)
commitf74678a19ddb4a8b54cc87bd7324308d1e785071
treee675b7a0d660751e92a34c2d55c4bb4569ce87ce
parent03c8b67e8b9a662f90a8bfd9e88b7914c05bfa0c
net/bpfilter: fix dprintf usage for /dev/kmsg

The bpfilter UMH code was recently changed to log its informative messages to
/dev/kmsg, however this interface doesn't support SEEK_CUR yet, used by
dprintf(). As result dprintf() returns -EINVAL and doesn't log anything.

However there already had some discussions about supporting SEEK_CUR into
/dev/kmsg interface in the past it wasn't concluded. Since the only user of
that from userspace perspective inside the kernel is the bpfilter UMH
(userspace) module it's better to correct it here instead waiting a conclusion
on the interface.

Fixes: 6eeced1d1e3f ("net: bpfilter: print umh messages to /dev/kmsg")
Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/bpfilter/main.c