]> git.baikalelectronics.ru Git - kernel.git/commit
pty: return EINVAL for TIOCGPTN for BSD ptys
authorJiri Slaby <jslaby@suse.cz>
Fri, 11 Jan 2013 11:06:27 +0000 (12:06 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 17 Jan 2013 21:56:57 +0000 (13:56 -0800)
commitf6f3c8226b50c2dc33d487a660c0e04766c48c53
treec8380e7cc90a4d32bee401f3770ee9ff82f8cb96
parentd5e9d7992d18f1f982a32cab7c1b02fa3f4ad06d
pty: return EINVAL for TIOCGPTN for BSD ptys

Commit 1a3bf7456322ff71afd0e7c18e9d5ce4f517f9bc (drivers:tty:fix up
ENOIOCTLCMD error handling) changed the default return value from tty
ioctl to be ENOTTY and not EINVAL. This is appropriate.

But in case of TIOCGPTN for the old BSD ptys glibc started failing
because it expects EINVAL to be returned. Only then it continues to
obtain the pts name the other way around.

So fix this case by explicit return of EINVAL in this case.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Reported-by: Florian Westphal <fw@strlen.de>
Cc: Alan Cox <alan@linux.intel.com>
Cc: stable <stable@vger.kernel.org> # 3.7+
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/pty.c