]> git.baikalelectronics.ru Git - kernel.git/commit
ARM: imx: fix .is_enabled() of shared gate clock
authorShawn Guo <shawn.guo@freescale.com>
Tue, 16 Sep 2014 01:35:33 +0000 (09:35 +0800)
committerOlof Johansson <olof@lixom.net>
Tue, 23 Sep 2014 04:49:20 +0000 (21:49 -0700)
commitf6d1f7a2f846aa98c2ae0ac265870f94f519b1cb
tree83a08cfcbec88aca04126674d0130f6a257c3e6b
parent05e6fab709722fe24162545310b18b9ab7bbc54b
ARM: imx: fix .is_enabled() of shared gate clock

Commit d856dae42e73 ("ARM: imx: fix shared gate clock") attempted to fix
an issue with particular enable/disable sequence from two shared gate
clocks.  But unfortunately, while it partially fixed the issue, it also
did something wrong in .is_enabled() function hook.  In case of shared
gate, the function shouldn't really query the hardware state via
share_count, because the function is trying to query the enabling state
of the clock in question, not the hardware state which is shared by
multiple clocks.

Fix the issue by returning the enable_count of the clock itself which is
maintained by clock core, in case it's a clock sharing hardware gate
with others.  As the result, the initialization of share_count per
hardware state is not needed now.  So remove it.

Reported-by: Fabio Estevam <fabio.estevam@freescale.com>
Fixes: d856dae42e73 ("ARM: imx: fix shared gate clock")
Cc: <stable@vger.kernel.org>
Signed-off-by: Shawn Guo <shawn.guo@freescale.com>
Tested-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Olof Johansson <olof@lixom.net>
arch/arm/mach-imx/clk-gate2.c