]> git.baikalelectronics.ru Git - kernel.git/commit
xfs: Fix error code in 'xfs_ioc_getbmap()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Tue, 6 Nov 2018 15:50:50 +0000 (07:50 -0800)
committerDarrick J. Wong <darrick.wong@oracle.com>
Tue, 6 Nov 2018 15:50:50 +0000 (07:50 -0800)
commitf68291a7a172dcda94277afdf9f51e27ae8cbd4c
treee75c67056ddc474f967da3b0396586c970d58968
parentf630c74755763954e46ada22cb887770a3c4fdd4
xfs: Fix error code in 'xfs_ioc_getbmap()'

In this function, once 'buf' has been allocated, we unconditionally
return 0.
However, 'error' is set to some error codes in several error handling
paths.
Before commit 29a3e8cd9447 ("xfs: simplify the xfs_getbmap interface")
this was not an issue because all error paths were returning directly,
but now that some cleanup at the end may be needed, we must propagate the
error code.

Fixes: 29a3e8cd9447 ("xfs: simplify the xfs_getbmap interface")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
fs/xfs/xfs_ioctl.c