]> git.baikalelectronics.ru Git - kernel.git/commit
drm/amd/display: Fix vblank and pageflip event handling for FreeSync
authorNicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Wed, 6 May 2020 19:47:54 +0000 (15:47 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 7 May 2020 20:24:37 +0000 (16:24 -0400)
commitf5ecbae0dec526dc3e12673d7c26f65b27293971
tree9996d7861f44259c6369135f6e3c70b9e1cc0b62
parentfa3c329c18043d52bee5ea64f5a59f6e17261017
drm/amd/display: Fix vblank and pageflip event handling for FreeSync

[Why]
We're sending the drm vblank event a frame too early in the case where
the pageflip happens close to VUPDATE and ends up blocking the signal.

The implementation in DM was previously correct *before* we started
sending vblank events from VSTARTUP unconditionally to handle cases
where HUBP was off, OTG was ON and userspace was still requesting some
DRM planes enabled. As part of that patch series we dropped VUPDATE
since it was deemed close enough to VSTARTUP, but there's a key
difference betweeen VSTARTUP and VUPDATE - the VUPDATE signal can be
blocked if we're holding the pipe lock.

There was a fix recently to revert the unconditional behavior for the
DCN VSTARTUP vblank event since it was sending the pageflip event on
the wrong frame - once again, due to blocking VUPDATE and having the
address start scanning out two frames later.

The problem with this fix is it didn't update the logic that calls
drm_crtc_handle_vblank(), so the timestamps are totally bogus now.

[How]
Essentially reverts most of the original VSTARTUP series but retains
the behavior to send back events when active planes == 0.

Some refactoring/cleanup was done to not have duplicated code in both
the handlers.

Fixes: 833776a3d0ce ("drm/amd/display: Send vblank and user events at vsartup for DCN")
Fixes: d5ac8e8f75dd ("drm/amd/display: Disable VUpdate interrupt for DCN hardware")
Fixes: fdd2c7ca8544 ("drm/amd/display: Fix pageflip event race condition for DCN.")
Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Reviewed-by: Leo Li <sunpeng.li@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c