]> git.baikalelectronics.ru Git - kernel.git/commit
drbd: fix an invalid memory access caused by incorrect use of list iterator
authorXiaomeng Tong <xiam0nd.tong@gmail.com>
Wed, 6 Apr 2022 19:04:44 +0000 (21:04 +0200)
committerJens Axboe <axboe@kernel.dk>
Wed, 6 Apr 2022 19:07:52 +0000 (13:07 -0600)
commitf52552d1e62c29e588f366aa677be8ffff520919
tree90cade8b7fa9f51674be457dccd68f53293f7a5a
parent75b35da44ef459281510c20497b8578f582b58e0
drbd: fix an invalid memory access caused by incorrect use of list iterator

The bug is here:
idr_remove(&connection->peer_devices, vnr);

If the previous for_each_connection() don't exit early (no goto hit
inside the loop), the iterator 'connection' after the loop will be a
bogus pointer to an invalid structure object containing the HEAD
(&resource->connections). As a result, the use of 'connection' above
will lead to a invalid memory access (including a possible invalid free
as idr_remove could call free_layer).

The original intention should have been to remove all peer_devices,
but the following lines have already done the work. So just remove
this line and the unneeded label, to fix this bug.

Cc: stable@vger.kernel.org
Fixes: 61c4103b3b7d8 ("drbd: Turn connection->volumes into connection->peer_devices")
Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
Reviewed-by: Christoph Böhmwalder <christoph.boehmwalder@linbit.com>
Reviewed-by: Lars Ellenberg <lars.ellenberg@linbit.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
drivers/block/drbd/drbd_main.c