]> git.baikalelectronics.ru Git - kernel.git/commit
x86/apic/vector: Fix off by one in error path
authorThomas Gleixner <tglx@linutronix.de>
Tue, 16 Jan 2018 11:20:18 +0000 (12:20 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Wed, 17 Jan 2018 11:11:36 +0000 (12:11 +0100)
commitf4e1d91d58fd48110e311d2d064c75bb0105b04e
tree92a37940d59f32572927961c3efd0b9e22cd69af
parentaa8e2d4fc6c20d7d28dd66dd8ec2cbf17474fa68
x86/apic/vector: Fix off by one in error path

Keith reported the following warning:

WARNING: CPU: 28 PID: 1420 at kernel/irq/matrix.c:222 irq_matrix_remove_managed+0x10f/0x120
  x86_vector_free_irqs+0xa1/0x180
  x86_vector_alloc_irqs+0x1e4/0x3a0
  msi_domain_alloc+0x62/0x130

The reason for this is that if the vector allocation fails the error
handling code tries to free the failed vector as well, which causes the
above imbalance warning to trigger.

Adjust the error path to handle this correctly.

Fixes: bba1808ba7e3 ("x86/irq: Use hierarchical irqdomain to manage CPU interrupt vectors")
Reported-by: Keith Busch <keith.busch@intel.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Tested-by: Keith Busch <keith.busch@intel.com>
Cc: stable@vger.kernel.org
Link: https://lkml.kernel.org/r/alpine.DEB.2.20.1801161217300.1823@nanos
arch/x86/kernel/apic/vector.c