]> git.baikalelectronics.ru Git - kernel.git/commit
net: stmmac: WARN if tx_skbuff entries are reused before cleared
authorNiklas Cassel <niklas.cassel@axis.com>
Mon, 19 Feb 2018 17:11:11 +0000 (18:11 +0100)
committerDavid S. Miller <davem@davemloft.net>
Tue, 20 Feb 2018 19:13:18 +0000 (14:13 -0500)
commitf42a8b66102c9163884a18ee664ba05c846829b9
treebf88b22a04f84a153625a85f188eec18ef2d70a4
parent1ed8d1b2884d05bc77cfafc418ad075db59426d3
net: stmmac: WARN if tx_skbuff entries are reused before cleared

The current code assumes that a tx_skbuff entry has been cleared
by stmmac_tx_clean() before stmmac_xmit()/stmmac_tso_xmit()
assigns a new skb to that entry. However, since we never check
the current value before overwriting it, it is theoretically
possible that a non-NULL value is overwritten.

Add WARN_ONs to verify that each entry in tx_skbuff is NULL
before it is assigned a new value.

Signed-off-by: Niklas Cassel <niklas.cassel@axis.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c