]> git.baikalelectronics.ru Git - kernel.git/commit
net: davinci_emac: Replace devm_request_irq with request_irq
authorChristian Riesch <christian.riesch@omicron.at>
Mon, 24 Mar 2014 12:46:26 +0000 (13:46 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 24 Mar 2014 19:32:03 +0000 (15:32 -0400)
commitf42568a1a897ea47e8d0bc51c7f663f88378f0c8
tree26aec0e59cfad25d27c772f8191bf75c039c67c0
parent8e5e22c2b505ab46469eb93f1b7592eca37dec1e
net: davinci_emac: Replace devm_request_irq with request_irq

In commit 40c4b0a29b8a6ceb8b04ba76d3271dd00cebcd17

Author: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Date:   Tue Jun 25 21:24:51 2013 +0530
net: davinci: emac: Convert to devm_* api

the call of request_irq is replaced by devm_request_irq and the call
of free_irq is removed. But since interrupts are requested in
emac_dev_open, doing ifconfig up/down on the board requests the
interrupts again each time, causing devm_request_irq to fail. The
interface is dead until the device is rebooted.

This patch reverts said commit partially: It changes the driver back
to use request_irq instead of devm_request_irq, puts free_irq back in
place, but keeps the remaining changes of the original patch.

Reported-by: Jon Ringle <jon@ringle.org>
Signed-off-by: Christian Riesch <christian.riesch@omicron.at>
Cc: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ti/davinci_emac.c