]> git.baikalelectronics.ru Git - kernel.git/commit
drm/i915: don't do allocate_va_range again on PIN_UPDATE
authorMatthew Auld <matthew.auld@intel.com>
Fri, 12 May 2017 09:14:23 +0000 (10:14 +0100)
committerChris Wilson <chris@chris-wilson.co.uk>
Fri, 12 May 2017 12:37:25 +0000 (13:37 +0100)
commitf41b304d9207db3423eb35a81ade8969473aae7e
tree5c16cec7ad18db62ea1c3e34657c51f0429ebbf5
parent329bcd8bc0b2132b351c3505b441267a8a776ecd
drm/i915: don't do allocate_va_range again on PIN_UPDATE

If a vma is already bound to a ppgtt, we incorrectly call
allocate_va_range again when doing a PIN_UPDATE, which will result in
over accounting within our paging structures, such that when we do
unbind something we don't actually destroy the structures and end up
inadvertently recycling them. In reality this probably isn't too bad,
but once we start touching PDEs and PDPEs for 64K/2M/1G pages this
apparent recycling will manifest into lots of really, really subtle
bugs.

v2: Fix the testing of vma->flags for aliasing_ppgtt_bind_vma

Fixes: d37a5f8e1a77 ("drm/i915: Move allocate_va_range to GTT")
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: http://patchwork.freedesktop.org/patch/msgid/20170512091423.26085-1-chris@chris-wilson.co.uk
drivers/gpu/drm/i915/i915_gem_gtt.c