]> git.baikalelectronics.ru Git - kernel.git/commit
net: stmmac: clean up impossible condition
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 16 Mar 2022 08:37:44 +0000 (11:37 +0300)
committerPaolo Abeni <pabeni@redhat.com>
Thu, 17 Mar 2022 12:40:35 +0000 (13:40 +0100)
commitf3acec349ff28987eccbe3ce64c78da29a6619bc
treed1947a507739ab1d7799c574f236498fc838bf96
parentff0b0cee3156bf9d471cddbb83ea43353a7f8f92
net: stmmac: clean up impossible condition

This code works but it has a static checker warning:

    drivers/net/ethernet/stmicro/stmmac/stmmac_main.c:1687 init_dma_rx_desc_rings()
    warn: always true condition '(queue >= 0) => (0-u32max >= 0)'

Obviously, it makes no sense to check if an unsigned int is >= 0.  What
prevents this code from being a forever loop is that later there is a
separate check for if (queue == 0).

The "queue" variable is less than MTL_MAX_RX_QUEUES (8) so it can easily
fit in an int type.  Any larger value for "queue" would lead to an array
overflow when we assign "rx_q = &priv->rx_queue[queue]".

Fixes: fc6b132cef84 ("net: stmmac: rearrange RX and TX desc init into per-queue basis")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20220316083744.GB30941@kili
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c