]> git.baikalelectronics.ru Git - kernel.git/commit
ibmvnic: avoid calling napi_disable() twice
authorLijun Pan <lijunp213@gmail.com>
Wed, 14 Apr 2021 07:46:14 +0000 (02:46 -0500)
committerDavid S. Miller <davem@davemloft.net>
Wed, 14 Apr 2021 20:10:58 +0000 (13:10 -0700)
commitf3656474ac4580bc317becc3a1711e3544c019e7
treed08a30c883146b03332e2878b1b269d0922deb4c
parent9154eefe0f6a11a1b22d1dddab731535cef3073c
ibmvnic: avoid calling napi_disable() twice

__ibmvnic_open calls napi_disable without checking whether NAPI polling
has already been disabled or not. This could cause napi_disable
being called twice, which could generate deadlock. For example,
the first napi_disable will spin until NAPI_STATE_SCHED is cleared
by napi_complete_done, then set it again.
When napi_disable is called the second time, it will loop infinitely
because no dev->poll will be running to clear NAPI_STATE_SCHED.

To prevent above scenario from happening, call ibmvnic_napi_disable()
which checks if napi is disabled or not before calling napi_disable.

Fixes: e3e244815030 ("ibmvnic: Move resource initialization to its own routine")
Suggested-by: Thomas Falcon <tlfalcon@linux.ibm.com>
Signed-off-by: Lijun Pan <lijunp213@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ibm/ibmvnic.c