]> git.baikalelectronics.ru Git - kernel.git/commit
sfc: return errors from efx_mcdi_set_id_led, and de-indirect
authorEdward Cree <ecree@solarflare.com>
Fri, 28 Aug 2020 17:51:04 +0000 (18:51 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 31 Aug 2020 19:28:50 +0000 (12:28 -0700)
commitf2ed621fad08773a825994e479a5743b89c0530d
treea8526e2041e98392cba4ff5fea815c4e545c6847
parentb1d11fdbe5b3cad457603d27aa30a29c0d119dc1
sfc: return errors from efx_mcdi_set_id_led, and de-indirect

W=1 warnings indicated that 'rc' was unused in efx_mcdi_set_id_led();
 change the function to return int instead of void and plumb the rc
 through the caller efx_ethtool_phys_id().
Since (post-Falcon) all sfc NICs use MCDI for this, there's no point in
 indirecting through a nic_type method, so remove that and just call
 efx_mcdi_set_id_led() directly.

Signed-off-by: Edward Cree <ecree@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/sfc/ef10.c
drivers/net/ethernet/sfc/ethtool.c
drivers/net/ethernet/sfc/mcdi.c
drivers/net/ethernet/sfc/mcdi.h
drivers/net/ethernet/sfc/net_driver.h
drivers/net/ethernet/sfc/siena.c