]> git.baikalelectronics.ru Git - kernel.git/commit
mptcp: more stable diag self-tests
authorPaolo Abeni <pabeni@redhat.com>
Fri, 7 Aug 2020 16:31:00 +0000 (18:31 +0200)
committerDavid S. Miller <davem@davemloft.net>
Sat, 8 Aug 2020 00:25:38 +0000 (17:25 -0700)
commitf2ad9d90451b09d98c9cbe23e8e6148563012a87
treedcf22b83fa5226cf96dad5be3c3337f7f487bb52
parent7b0f7f1ac0c559c746082d072fd881da6693dea5
mptcp: more stable diag self-tests

During diag self-tests we introduce long wait in the mptcp test
program to give the script enough time to access the sockets
dump.

Such wait is introduced after shutting down one sockets end. Since
commit 93d3b913d64c ("mptcp: Use full MPTCP-level disconnect state
machine") if both sides shutdown the socket is correctly transitioned
into CLOSED status.

As a side effect some sockets are not dumped via the diag interface,
because the socket state (CLOSED) does not match the default filter, and
this cause self-tests instability.

Address the issue moving the above mentioned wait before shutting
down the socket.

Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/68
Fixes: 6aaaa43642d2 ("selftests/mptcp: add diag interface tests")
Tested-and-acked-by: Matthieu Baerts <matthieu.baerts@tessares.net>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
tools/testing/selftests/net/mptcp/mptcp_connect.c