]> git.baikalelectronics.ru Git - kernel.git/commit
bridge: switchdev: Clear forward mark when transmitting packet
authorIdo Schimmel <idosch@mellanox.com>
Fri, 1 Sep 2017 09:22:25 +0000 (12:22 +0300)
committerDavid S. Miller <davem@davemloft.net>
Fri, 1 Sep 2017 17:11:28 +0000 (10:11 -0700)
commitf277e97470dd3dcf6234f2e1106ed467b571cb72
tree9dd0f2cca668a57493ca09872ba8dae46c8df764
parent2661143fbe4754fb8a279aac3490f3426492c8ea
bridge: switchdev: Clear forward mark when transmitting packet

Commit b76257fc9270 ("bridge: switchdev: Add forward mark support for
stacked devices") added the 'offload_fwd_mark' bit to the skb in order
to allow drivers to indicate to the bridge driver that they already
forwarded the packet in L2.

In case the bit is set, before transmitting the packet from each port,
the port's mark is compared with the mark stored in the skb's control
block. If both marks are equal, we know the packet arrived from a switch
device that already forwarded the packet and it's not re-transmitted.

However, if the packet is transmitted from the bridge device itself
(e.g., br0), we should clear the 'offload_fwd_mark' bit as the mark
stored in the skb's control block isn't valid.

This scenario can happen in rare cases where a packet was trapped during
L3 forwarding and forwarded by the kernel to a bridge device.

Fixes: b76257fc9270 ("bridge: switchdev: Add forward mark support for stacked devices")
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Reported-by: Yotam Gigi <yotamg@mellanox.com>
Tested-by: Yotam Gigi <yotamg@mellanox.com>
Reviewed-by: Jiri Pirko <jiri@mellanox.com>
Acked-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/bridge/br_device.c