]> git.baikalelectronics.ru Git - kernel.git/commit
net: dsa: felix: access QSYS_TAG_CONFIG under tas_lock in vsc9959_sched_speed_set
authorVladimir Oltean <vladimir.oltean@nxp.com>
Mon, 5 Sep 2022 17:01:25 +0000 (20:01 +0300)
committerDavid S. Miller <davem@davemloft.net>
Wed, 7 Sep 2022 12:44:04 +0000 (13:44 +0100)
commitf26f296c041cddac11117294d6f5c3f890bab04e
tree76345a71558bc55469a3bf04dd39f975c54a8545
parent77803be20c399a931a0d772eb250aba6a1684b69
net: dsa: felix: access QSYS_TAG_CONFIG under tas_lock in vsc9959_sched_speed_set

The read-modify-write of QSYS_TAG_CONFIG from vsc9959_sched_speed_set()
runs unlocked with respect to the other functions that access it, which
are vsc9959_tas_guard_bands_update(), vsc9959_qos_port_tas_set() and
vsc9959_tas_clock_adjust(). All the others are under ocelot->tas_lock,
so move the vsc9959_sched_speed_set() access under that lock as well, to
resolve the concurrency.

Fixes: eb99ed107125 ("net: dsa: felix: drop oversized frames with tc-taprio instead of hanging the port")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/ocelot/felix_vsc9959.c